Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added elvish syntax #948

Closed
wants to merge 1 commit into from
Closed

added elvish syntax #948

wants to merge 1 commit into from

Conversation

rsteube
Copy link
Contributor

@rsteube rsteube commented Apr 25, 2020

added syntax for Elvish Shell

Listed as sublime language support here: https://github.com/elves/awesome-elvish

@sharkdp
Copy link
Owner

sharkdp commented Apr 25, 2020

Welcome and thank you for your PR.

Have you seen the "syntax request" issue type (https://github.com/sharkdp/bat/issues/new?assignees=&labels=syntax-request&template=syntax_request.md&title=) and, in particular, the guideline for adding new syntaxes?

Also, note that there is an easy way to customize your version of bat: https://github.com/sharkdp/bat#adding-new-syntaxes--language-definitions

@rsteube
Copy link
Contributor Author

rsteube commented Apr 25, 2020

ah, no didn't see that part with the 10.000 downloads - 31 is pretty far from that XD
i got it working locally, just thought it might be useful for others as well

@rsteube rsteube closed this Apr 25, 2020
@data-man
Copy link

data-man commented Oct 5, 2020

@sharkdp

please make sure that it meets our
guidelines for adding new syntaxes:
10,000 downloads on packagecontrol.io

But why? :(
I want to make PR for Zig language, but Zig Language package has 1K downloads only.
Please, can you relax this requirement?

@sharkdp
Copy link
Owner

sharkdp commented Oct 5, 2020

Have you seen that it's possible to customize bat? https://github.com/sharkdp/bat#adding-new-syntaxes--language-definitions

@data-man
Copy link

data-man commented Oct 5, 2020

Sure, but Zig's support in the official build is preferable. :)

@rsteube
Copy link
Contributor Author

rsteube commented Oct 5, 2020

Yes is easy enough to customize, would by nice though to have a single command solution to add these or a system-wide config-dir to add these using the system package-manager (e.g. bat-syntax-zig).

@sharkdp
Copy link
Owner

sharkdp commented Oct 5, 2020

@data-man: If you like, you could open a new ticket to discuss the 10k downloads policy. I'm pretty sure it's not ideal, but I wanted to have something to limit the amount of syntaxes that we need to maintain. bat startup speed is also a big concern.

@rsteube excellent points. Maybe we could also list them in that new ticket where others can also see them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants